ind issueshttps://code.greenhost.net/totem/ind/-/issues2021-09-16T12:41:33Zhttps://code.greenhost.net/totem/ind/-/issues/37Move code to an Interaction class to improve maintainability2021-09-16T12:41:33ZArie PetersonMove code to an Interaction class to improve maintainabilityThe following discussion from !21 should be addressed:
- [ ] @remon started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/21#note_19251):
> I love how the code in this switch statement has no lines longer than...The following discussion from !21 should be addressed:
- [ ] @remon started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/21#note_19251):
> I love how the code in this switch statement has no lines longer than 80 characters, even at indentation level eight :wink: But it is usually a good indicator (code smell) that code should be extracted. In this case I think it would be nice to define the classes `PopupAction` and `HighlightAction`, each having an `applyTo(graph, target)` function. Or one class to rule them all and in the `darkness.bind()` them, but there already is an `Action` class in mxGraph. On second thought, an `Interaction` class is probably more useful, and would allow some other improvements elsewhere.
>
> Please close this discussion by creating a new issue, titled something like "Move code to an Interaction class to improve maintainability", to be solved later.https://code.greenhost.net/totem/ind/-/issues/69Double highlight if you click after mouse over2021-09-16T12:35:00ZRemon HuijtsDouble highlight if you click after mouse overThe following discussion from !47 should be addressed:
- [ ] @maarten started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/47#note_64406): (+3 comments)
> Not sure if this can or should be prevented, but I ca...The following discussion from !47 should be addressed:
- [ ] @maarten started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/47#note_64406): (+3 comments)
> Not sure if this can or should be prevented, but I can get 2 highlights by hovering first and then clicking.https://code.greenhost.net/totem/ind/-/issues/75common.css does not exist2021-09-16T12:10:09ZMaarten de Waardcommon.css does not exist`paver collect_static` combines all the CSS files in 1 file. But the mxgraph javascript still tries to load `common.css`. This leads to a 404 error.
It's not really a problem, because the css is still present in the `grapheditorxblock....`paver collect_static` combines all the CSS files in 1 file. But the mxgraph javascript still tries to load `common.css`. This leads to a 404 error.
It's not really a problem, because the css is still present in the `grapheditorxblock.css` file, so functionally nothing changes. However, it *does* lead to problems in the console.
It also leads to `The resource from “https://learn.staging.totem-project.org/static/xblock/resources/grapheditorxblock/public/css/common.css” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).e549e7b2ec0b4f4ba5d6992cfe0d8543` as reported in tutor-server#33