ind issueshttps://code.greenhost.net/totem/ind/-/issues2021-09-16T12:41:33Zhttps://code.greenhost.net/totem/ind/-/issues/37Move code to an Interaction class to improve maintainability2021-09-16T12:41:33ZArie PetersonMove code to an Interaction class to improve maintainabilityThe following discussion from !21 should be addressed:
- [ ] @remon started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/21#note_19251):
> I love how the code in this switch statement has no lines longer than...The following discussion from !21 should be addressed:
- [ ] @remon started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/21#note_19251):
> I love how the code in this switch statement has no lines longer than 80 characters, even at indentation level eight :wink: But it is usually a good indicator (code smell) that code should be extracted. In this case I think it would be nice to define the classes `PopupAction` and `HighlightAction`, each having an `applyTo(graph, target)` function. Or one class to rule them all and in the `darkness.bind()` them, but there already is an `Action` class in mxGraph. On second thought, an `Interaction` class is probably more useful, and would allow some other improvements elsewhere.
>
> Please close this discussion by creating a new issue, titled something like "Move code to an Interaction class to improve maintainability", to be solved later.https://code.greenhost.net/totem/ind/-/issues/62Bug: bullet point in text box2021-02-15T13:39:01ZSylvain MignotBug: bullet point in text boxBehaviour: Two boxes in an INDie diagram have bullet points on LMS. They do not appear on Studio, the text editor shows there are no bullet points there.
Desirable behaviour: remove the bullet points.
![BulletPointINDie](/uploads/8a4ec4...Behaviour: Two boxes in an INDie diagram have bullet points on LMS. They do not appear on Studio, the text editor shows there are no bullet points there.
Desirable behaviour: remove the bullet points.
![BulletPointINDie](/uploads/8a4ec4652e22336b0b0a5954a65bb37c/BulletPointINDie.png)https://code.greenhost.net/totem/ind/-/issues/69Double highlight if you click after mouse over2021-09-16T12:35:00ZRemon HuijtsDouble highlight if you click after mouse overThe following discussion from !47 should be addressed:
- [ ] @maarten started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/47#note_64406): (+3 comments)
> Not sure if this can or should be prevented, but I ca...The following discussion from !47 should be addressed:
- [ ] @maarten started a [discussion](https://code.greenhost.net/totem/ind/merge_requests/47#note_64406): (+3 comments)
> Not sure if this can or should be prevented, but I can get 2 highlights by hovering first and then clicking.https://code.greenhost.net/totem/ind/-/issues/70Fix "End previous interaction" for mobile2021-05-06T08:59:59ZSylvain MignotFix "End previous interaction" for mobileIssue: On mobile phones, the interaction feature #50 does not stop the interaction when removing finger from the screen or when clicking on another interaction.
Behaviour: Several or all interactions appear at the same time, messing up ...Issue: On mobile phones, the interaction feature #50 does not stop the interaction when removing finger from the screen or when clicking on another interaction.
Behaviour: Several or all interactions appear at the same time, messing up with the INDie and what the learner is supposed to understand.
Expected behaviour: On desktop, when the mouse pointer leaves the area of interaction, interaction disappears/stops.
Potential solutions [phone]:
* When clicking/tiping somewhere else on diagram, the next interaction stops the previous one?
* Use the hide feature somehow?https://code.greenhost.net/totem/ind/-/issues/71Clicking does not work on some mobile browsers2021-09-16T12:22:05ZRemon HuijtsClicking does not work on some mobile browsers@Sylvain reported in #50 that tapping, clicking nor long pressing seems to work on INDie diagrams on his phone, when testing a [diagram](https://learn.totem-project.org/courses/course-v1:Totem+TP_SMR_EN+001/courseware/726fb7fe2b544d479ac...@Sylvain reported in #50 that tapping, clicking nor long pressing seems to work on INDie diagrams on his phone, when testing a [diagram](https://learn.totem-project.org/courses/course-v1:Totem+TP_SMR_EN+001/courseware/726fb7fe2b544d479acdef58fb296b6d/b519c78b61154e4d84f976268e847add/?activate_block_id=block-v1%3ATotem%2BTP_SMR_EN%2B001%2Btype%40sequential%2Bblock%40b519c78b61154e4d84f976268e847add) of the Social Media Research course.
Browser: Firefox, Android 9 (lineage OS). It works on the same phone but with Brave.https://code.greenhost.net/totem/ind/-/issues/72Refactor code to separate concerns2021-02-15T13:39:08ZRemon HuijtsRefactor code to separate concernsThis is not a bug, but just a list of possible code improvements that I had written down on paper earlier.
- Centralize rule parsing.
- Separate properly or merge completely UI and non-UI models.
- Move `pickCell()` and/or `allNodes()` ...This is not a bug, but just a list of possible code improvements that I had written down on paper earlier.
- Centralize rule parsing.
- Separate properly or merge completely UI and non-UI models.
- Move `pickCell()` and/or `allNodes()` functions to proper container.
- Investigate the dangling cellValue object (might have been addressed already).
- Rename some functions/classes for clarity and consistency.
See also #37https://code.greenhost.net/totem/ind/-/issues/76Experiment with responsive iFrames2022-09-09T05:58:57ZMaarten de WaardExperiment with responsive iFramesAs asked in js-totp-problem#48
Most of our theme is now responsive, but the js exercises include iframes. We should try making those responsive.As asked in js-totp-problem#48
Most of our theme is now responsive, but the js exercises include iframes. We should try making those responsive.Alina RunovaAlina Runovahttps://code.greenhost.net/totem/ind/-/issues/75common.css does not exist2021-09-16T12:10:09ZMaarten de Waardcommon.css does not exist`paver collect_static` combines all the CSS files in 1 file. But the mxgraph javascript still tries to load `common.css`. This leads to a 404 error.
It's not really a problem, because the css is still present in the `grapheditorxblock....`paver collect_static` combines all the CSS files in 1 file. But the mxgraph javascript still tries to load `common.css`. This leads to a 404 error.
It's not really a problem, because the css is still present in the `grapheditorxblock.css` file, so functionally nothing changes. However, it *does* lead to problems in the console.
It also leads to `The resource from “https://learn.staging.totem-project.org/static/xblock/resources/grapheditorxblock/public/css/common.css” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).e549e7b2ec0b4f4ba5d6992cfe0d8543` as reported in tutor-server#33