Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • ind ind
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • totemtotem
  • indind
  • Issues
  • #55
Closed
Open
Issue created Apr 03, 2019 by Remon Huijts@remonMaintainer

saveFile() tries to call a non-function callback

In grapheditorxblock/src/js/grapheditorxblock.js we have a saveFile() function that is supposed to be called with a callback functions as a parameter. Apparently the check we do on that does not suffice:

if (typeof callback != "undefined")
    callback();

This can result in the following JavaScript error: TypeError: callback is not a function

Not sure if this is relevant: I consistently get that error (hidden in the console of course) when saving in the studio view in my local development environment while testing the graphxblock stand-alone. I have not yet tested other situations. Even with that error message, saving seems to work fine, so this is a low-priority issue.

Assignee
Assign to
Time tracking